fixed GROUP BY issue with expressions #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please rebase this and fix the failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this issue: #12
It was due to a specificity of MSSQL used through pyodbc that doesn't allow using a column in an expression without referring to it in the GROUP BY clause.
In other terms, this is not allowed with MSSQL's sp_prepexec:
SELECT id, F(a) FROM ... GROUP BY id, F(a)
But should instead be:
SELECT id, F(a) FROM ... GROUP BY id, F(a), a
The PR should be compatible with 2.2, 3.0 and 3.1.